Make session share button + persist to local storage#72
Merged
sverhoeven merged 22 commits intomainfrom Nov 12, 2024
Merged
Conversation
Moves ShareButton from experiment to whole app TODO - [ ] Handle inline todos
Collaborator
Author
|
Uploading big experiment twice causes very slow setExperiments calls Fixing by storing outputs outside store. |
Collaborator
Author
Collaborator
Author
class-web/apps/class-solid/src/lib/store.ts Lines 90 to 93 in c9eaead |
Collaborator
Author
|
Fixes #63 or when a experiment is present the + button will show in dialog. |
Collaborator
Author
|
Rollback outputs premature optimization |
Partially reverts 0dff547
Collaborator
Author
|
Hmm, with outputs back in store, adding the permutation sweep, the ui is slower. Duplicating experiment is even slower. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Refs #61
Fixes #20
Moves ShareButton from experiment to whole app
TODO